Skip to content

[UID] Fix wrong use statement for generators #14429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2020
Merged

[UID] Fix wrong use statement for generators #14429

merged 1 commit into from
Oct 17, 2020

Conversation

loicsapone
Copy link
Contributor

No description provided.

wouterj
wouterj approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this change is 100% correct. Thanks!

https://github.com/symfony/symfony/tree/6088728c5e2cdc6ff1ab2b36d7ded4952cb1c6a6/src/Symfony/Bridge/Doctrine/IdGenerator

@wouterj wouterj added this to the 5.2 milestone Oct 16, 2020
Nyholm
Nyholm approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm mentioned this pull request Oct 16, 2020
Merged
@javiereguiluz
Copy link
Member

Loïc thanks for fixing this error and congrats on your first Symfony Docs contribution!

@javiereguiluz javiereguiluz merged commit fbd06ce into symfony:5.x Oct 17, 2020
javiereguiluz added a commit that referenced this pull request Oct 17, 2020
@javiereguiluz
minor #14432 Fixed broken use statements (Nyholm)
dc08a5a 
This PR was squashed before being merged into the 5.x branch.

Discussion
----------

Fixed broken use statements

Inspired by #14429 I decided to fix the other broken statements too.

Commits
-------

48c5e90 Fixed broken use statements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Uid
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
5 participants
@loicsapone @javiereguiluz @wouterj @Nyholm @carsonbot